Adding UserAgent Component #34
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* upstream/main: (54 commits) [Pager] Doctrine Bridge (SonsOfPHP#175) fuckery (SonsOfPHP#174) [Money] Add Twig Bridge (SonsOfPHP#173) docs coverage fix typo SonsOfPHP#63 | Link Component (SonsOfPHP#170) Pager Component (SonsOfPHP#134) Pager Contract (SonsOfPHP#133) Update README.md (SonsOfPHP#124) [Logger] Finish up Logger Component (SonsOfPHP#123) Makefile [Logger] New Component (SonsOfPHP#120) bug [HttpMessage] Helper Methods on Uri to make it easier to create Uri objects with query params (SonsOfPHP#119) bug fixes Bug fix Making a few changes and breaking shit (SonsOfPHP#118) updating a few docs (SonsOfPHP#117) typo ...
* main: Housekeeping (SonsOfPHP#203) [EventDispatcher] Adding a few new things and working on docs (SonsOfPHP#202) [Bard] various changes and updates (SonsOfPHP#201) Adding Churn PHP as a tool in the repo (SonsOfPHP#200) Update symfony/phpunit-bridge requirement from ^6 to ^6 || ^7 (SonsOfPHP#192) [Mailer] New Component and Contract (SonsOfPHP#190) [Mailer] New Component and Contract (SonsOfPHP#189) House Keeping (SonsOfPHP#188) [HttpHandler] Component (SonsOfPHP#187) [Container] New Component (SonsOfPHP#182) [Cookie] New Component & Contract (SonsOfPHP#181)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
=========================================
Coverage 73.33% 73.33%
Complexity 1362 1362
=========================================
Files 208 208
Lines 3308 3308
=========================================
Hits 2426 2426
Misses 882 882 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to have a User Agent object that is created based on the user agent string. This could be set a number of different ways.
UA - Represents the User Agent, should only contain get*, has*, is*, supports* (ie: getVersion, isBot, supportsJavasctipt) methods. Should also support __toString and be able to be serialized
UA Provider - Returns a UA object based on the UA string. I want the ability to have different UA providers so they can be chained together. For example, there could be a Bot UA Provider and Desktop UA Provider. Input is the UA string, output is the UA object
UA Locator - Can use files to store UA information. CSV, INI, XML, etc. The thought is, this could be injected into a UA Provider so that existing files could be used.
UA Builder - Allows providers to quickly build UA objects. Not sure if this would be needed or not
Exceptions - UnknownUserAgentException